Jetpack Cloud: Remove old site selection triggers

[tyxla]

Proposed Changes

We're removing the old site selection triggers in favor of the /sites screen that allows selection.

Why are these changes being made?

In all environments (Jetpack Cloud, Automattic for Agencies, WordPress.com) we already use /sites for selecting the current site. The old site selection picker is obsolete and only appears in a few awkward places. It is time to retire it for consistency.

This is part of a bigger initiative - unifying multisite dashboard experiences.

This step is one of the last pre-requisites to removing the old picker, which I'm addressing in #101844.

Testing Instructions

• Open Jetpack Cloud with a partner account.
• "All sites" at the top of the sidebar shouldn't be clickable anymore. The corresponding chevron down has also been removed.
• Go to /sites
• Select a site by clicking on it.
• The site name at the top of the sidebar shouldn't be clickable anymore. The corresponding chevron down has also been removed.

Screenshots

Without a selected site:

Before	After

With a selected site:

Before	After

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-138363

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-138363&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-138363&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~428 bytes removed 📉 [gzipped])

Details

name                             parsed_size           gzip_size
jetpack-cloud-plugin-management       -424 B  (-0.0%)     -138 B  (-0.0%)
jetpack-cloud-partner-portal          -424 B  (-0.0%)     -147 B  (-0.0%)
jetpack-cloud-overview                -424 B  (-0.1%)     -143 B  (-0.1%)
jetpack-cloud-agency-dashboard        -424 B  (-0.0%)     -147 B  (-0.0%)
jetpack-cloud                         -424 B  (-0.1%)     -143 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~143 bytes removed 📉 [gzipped])

Details

name                                                                              parsed_size           gzip_size
async-load-calypso-jetpack-cloud-sections-sidebar-navigation-manage-selected-...       -424 B  (-0.4%)     -143 B  (-0.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/old-site-selection-jetpack-cloud-sidebar on your sandbox.

[tyxla]

Yeah, looks like we'll need to add the Sites management screen for non-agency Jetpack Cloud users, it doesn't appear there (hat tip @jsnajdr for pointing that out):

I'll switch this to draft for now as I look at how this can be done with as little friction as possible. We still have the site selection middleware and the site selector component, so it shouldn't be a big deal with a small design change.

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a trunk merge or rebase and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

[tyxla]

Not planning more work on this for now. May revisit as the hosting dashboard matures. Thanks everyone!