Skip to content

open facebook and x sharing in new tab#101851

Closed
Addison-Stavlo wants to merge 1 commit intotrunkfrom
update/share-facebook-open-full-window
Closed

open facebook and x sharing in new tab#101851
Addison-Stavlo wants to merge 1 commit intotrunkfrom
update/share-facebook-open-full-window

Conversation

@Addison-Stavlo
Copy link
Contributor

Related to #

Proposed Changes

just a test idea for - https://github.com/Automattic/loop/issues/596, to see what it feels like to open facebook and x sharing links in a new tab.

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~119 bytes removed 📉 [gzipped])

Details
name                             parsed_size           gzip_size
reader                                -296 B  (-0.0%)     -119 B  (-0.0%)
plugins                               -296 B  (-0.0%)     -119 B  (-0.0%)
jetpack-cloud-plugin-management       -296 B  (-0.0%)     -119 B  (-0.0%)
home                                  -296 B  (-0.0%)     -119 B  (-0.0%)
a8c-for-agencies-plugins              -296 B  (-0.0%)     -119 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~119 bytes removed 📉 [gzipped])

Details
name                                                 parsed_size           gzip_size
async-load-design-blocks                                  -296 B  (-0.0%)     -119 B  (-0.0%)
async-load-calypso-components-web-preview-component       -296 B  (-0.1%)     -119 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/share-facebook-open-full-window on your sandbox.

@github-actions
Copy link

This PR has been marked as stale. This happened because:

  • It has been inactive for the past 3 months.
  • It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a trunk merge or rebase and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

@github-actions
Copy link

This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR.

@github-actions github-actions bot closed this Sep 14, 2025
@github-actions github-actions bot deleted the update/share-facebook-open-full-window branch September 14, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments