Skip to content

Conversation

@eoigal
Copy link
Contributor

@eoigal eoigal commented Mar 25, 2025

Fixes https://github.com/Automattic/loop/issues/373

Proposed Changes

  • This will show a confirmation modal if the user has subscriptions and they choose to pause emails

Why are these changes being made?

Testing Instructions

Screenshot 2025-03-29 at 00 02 27

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 25, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~15 bytes added 📈 [gzipped])

Details
name        parsed_size           gzip_size
entry-main        +41 B  (+0.0%)      +15 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1207 bytes added 📈 [gzipped])

Details
name                   parsed_size           gzip_size
notification-settings     +35550 B  (+5.1%)    +7322 B  (+3.6%)
reader                      +191 B  (+0.0%)      -13 B  (-0.0%)
security                    -103 B  (-0.0%)       -7 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 25, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/notification-settings on your sandbox.

@eoigal eoigal force-pushed the update/notification-settings branch 2 times, most recently from ba0a7e1 to c313623 Compare March 28, 2025 23:32
@eoigal eoigal force-pushed the update/notification-settings branch from bf8004a to 7afad1e Compare March 31, 2025 10:50
Copy link
Contributor

@spsiddarthan spsiddarthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eoigal eoigal merged commit e80e047 into trunk Mar 31, 2025
13 checks passed
@eoigal eoigal deleted the update/notification-settings branch March 31, 2025 12:35
@a8ci18n
Copy link

a8ci18n commented Mar 31, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17326926

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @eoigal for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 6, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants