Skip to content

Comments

Reader: Update notification toggles text for consistency#101856

Merged
mehmoodak merged 6 commits intotrunkfrom
calypso-97575/update-subscriptions-email-to-text-for-clarity
Mar 26, 2025
Merged

Reader: Update notification toggles text for consistency#101856
mehmoodak merged 6 commits intotrunkfrom
calypso-97575/update-subscriptions-email-to-text-for-clarity

Conversation

@mehmoodak
Copy link
Member

Related to #97575

Proposed Changes

In Reader, we currently display notification toggles using both dedicated components and ToggleControl. This pull request extends our existing dedicated components to enable their consistent use throughout the app.

Before After
image image
image No visual change
image image
image image

Why are these changes being made?

To enhance clarity and improve consistency.

Testing Instructions

  • Go to /reader/subscriptions. Click on ellipsis menu of any subscription and verify the toggles.
  • Go to subscriptions/comments. Click on ellipsis menu of any subscription and verify the toggles.
  • Go to /reader/subscriptions/[SUBS_ID]. Verify the toggles.
  • Go to /reader/recent/[FEEDID]. Open settings menu and verify the toggles.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mehmoodak mehmoodak self-assigned this Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 25, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~260 bytes added 📈 [gzipped])

Details
name                 parsed_size           gzip_size
entry-subscriptions      +1810 B  (+0.1%)     +260 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~199 bytes added 📈 [gzipped])

Details
name    parsed_size           gzip_size
reader      +1390 B  (+0.0%)     +199 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1615 bytes added 📈 [gzipped])

Details
name                      parsed_size           gzip_size
async-load-design-blocks      +4923 B  (+0.2%)    +1615 B  (+0.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mehmoodak mehmoodak marked this pull request as ready for review March 25, 2025 18:43
@mehmoodak mehmoodak requested a review from a team as a code owner March 25, 2025 18:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 25, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug calypso-97575/update-subscriptions-email-to-text-for-clarity on your sandbox.

Copy link
Contributor

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! Looks good!

@mehmoodak mehmoodak merged commit a1f917f into trunk Mar 26, 2025
13 checks passed
@mehmoodak mehmoodak deleted the calypso-97575/update-subscriptions-email-to-text-for-clarity branch March 26, 2025 03:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email sent by default when subscribing to a blog, even after turning off emails

3 participants