Reader: Update notification toggles text for consistency#101856
Reader: Update notification toggles text for consistency#101856
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~260 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~199 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1615 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
...nt/landing/subscriptions/components/settings/site-settings/notify-me-of-new-posts-toggle.tsx
Show resolved
Hide resolved
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
DustyReagan
left a comment
There was a problem hiding this comment.
Nice improvements! Looks good!
Related to #97575
Proposed Changes
In Reader, we currently display notification toggles using both dedicated components and
ToggleControl. This pull request extends our existing dedicated components to enable their consistent use throughout the app.Why are these changes being made?
To enhance clarity and improve consistency.
Testing Instructions
/reader/subscriptions. Click on ellipsis menu of any subscription and verify the toggles.subscriptions/comments. Click on ellipsis menu of any subscription and verify the toggles./reader/subscriptions/[SUBS_ID]. Verify the toggles./reader/recent/[FEEDID]. Open settings menu and verify the toggles.Pre-merge Checklist