Skip to content

Site picker: arrows didn't have any fill#101858

Merged
andres-blanco merged 1 commit intotrunkfrom
fix/arrow-fill-color-site-picker
Mar 26, 2025
Merged

Site picker: arrows didn't have any fill#101858
andres-blanco merged 1 commit intotrunkfrom
fix/arrow-fill-color-site-picker

Conversation

@andres-blanco
Copy link
Contributor

Closes #98994

Proposed Changes

Remove css rule that set the svg fill to none in the sitePicker.

Why are these changes being made?

The offending rule was added in this PR to prevent the search icon to have a blue fill, but it wasn't specific enough.

Testing Instructions

  • Apply this branch locally (or use the calypso.live link below if you have more than 96 sites)
  • If testing locally, add this change to force show the pagination
diff --git a/client/landing/stepper/declarative-flow/internals/steps-repository/site-picker/site-picker.tsx b/client/landing/stepper/declarative-flow/internals/steps-repository/site-picker/site-picker.tsx
index 66821bc8b1b..e79676f814f 100644
--- a/client/landing/stepper/declarative-flow/internals/steps-repository/site-picker/site-picker.tsx
+++ b/client/landing/stepper/declarative-flow/internals/steps-repository/site-picker/site-picker.tsx
@@ -32,7 +32,7 @@ const SitePicker = function SitePicker( props: Props ) {
        const { __ } = useI18n();
        const {
                page,
-               perPage = 96,
+               perPage = 8,
                search,
                status,
                onSelectSite,
  • Navigate to /setup/hosted-site-migration/sitePicker
  • Verify you don't see a blue search icon: image
  • Verify the arrows in the pagination are visible: image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andres-blanco andres-blanco requested a review from a team March 25, 2025 19:30
@andres-blanco andres-blanco self-assigned this Mar 25, 2025
@andres-blanco andres-blanco requested a review from a team as a code owner March 25, 2025 19:30
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/arrow-fill-color-site-picker on your sandbox.

Copy link
Contributor

@daledupreez daledupreez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@andres-blanco andres-blanco merged commit 67e8dc2 into trunk Mar 26, 2025
16 of 17 checks passed
@andres-blanco andres-blanco deleted the fix/arrow-fill-color-site-picker branch March 26, 2025 14:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Previous and Next buttons are missing arrows on the site picker

3 participants

Comments