Skip to content

Comments

Reader: Fix back button styles on logged out Discover signup flow#101860

Merged
artemiomorales merged 1 commit intotrunkfrom
fix/sign-up-back-button-styles
Mar 26, 2025
Merged

Reader: Fix back button styles on logged out Discover signup flow#101860
artemiomorales merged 1 commit intotrunkfrom
fix/sign-up-back-button-styles

Conversation

@artemiomorales
Copy link
Contributor

Related to #101584

Proposed Changes

  • Adds styles to override the Reader back button stylesheet

Before

Image

After

Screenshot 2025-03-25 at 20 35 48

Why are these changes being made?

  • The back button styles for the signup page are broken when going through the /discover flow because the Reader's styles are being included

Testing Instructions

  • Go to /discover while logged out
  • On the sign up screen, click 'Email'
  • Make sure the back button appears below the email input field as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@artemiomorales artemiomorales added the [Feature] Reader The reader site on Calypso. label Mar 25, 2025
@artemiomorales artemiomorales self-assigned this Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/sign-up-back-button-styles on your sandbox.

@artemiomorales artemiomorales requested a review from a team March 26, 2025 14:01
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
Copy link
Contributor

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tried signing up from /discover, /setup/domain-transfer/, and /setup/newsletter, and I don't see any regressions. ✅

@artemiomorales artemiomorales merged commit 1d31b0c into trunk Mar 26, 2025
16 checks passed
@artemiomorales artemiomorales deleted the fix/sign-up-back-button-styles branch March 26, 2025 16:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Reader The reader site on Calypso.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reader: Back button is misplaced in sign up flow from logged out Discover

3 participants