Remove useGoalsFirstExperiment from onboarding#101864
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~41 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
paulopmt1
force-pushed
the
update/remove-goalsfirst-references
branch
from
00539dc to
66f46e1
Compare
matticbot
added
the
[Status] Needs Review
paulopmt1
left a comment
paulopmt1
left a comment
There was a problem hiding this comment.
So far, so good!
I did a rebase, updated a file, and performed tests. Everything is working as expected.
| setGoals( refGoals[ refParameter ] ); | ||
| } | ||
| // Delibirately not including all deps in the deps array | ||
| // Deliberately not including all deps in the deps array |
There was a problem hiding this comment.
Thanks for also catching that!
| action, | ||
| is_goals_first: isGoalsAtFrontExperiment, | ||
| } ); | ||
| recordTracksEvent( 'calypso_signup_goals_nav_click', { action } ); |
github-actions
bot
removed
the
[Status] Needs Review
| siteUrl, | ||
| progress, | ||
| partnerBundle, | ||
| siteGoals, |
There was a problem hiding this comment.
Can we also remove the siteGoals: select( ONBOARD_STORE ).getGoals() line inside the useSelect ?
There was a problem hiding this comment.
This looks like a missed opportunity.
5 participants
Related to # #101759
This is the first of multiple PRs that will remove GoalsFirst code.
Proposed Changes
useGoalsFirstExperimentWhy are these changes being made?
Leadership has confirmed we will not be resurrecting the Goals First onboarding flow. We can remove all traces of this flow.
Testing Instructions
Pre-merge Checklist