Skip to content

Comments

Site Migration: Redirect user back to import list based on the ref#101896

Merged
gabrielcaires merged 1 commit intotrunkfrom
fix/back-button-from-import-list
Mar 27, 2025
Merged

Site Migration: Redirect user back to import list based on the ref#101896
gabrielcaires merged 1 commit intotrunkfrom
fix/back-button-from-import-list

Conversation

@gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Mar 26, 2025

Related to:

Proposed Changes

  • Redirect users back to the import list when they come from there.

Why are these changes being made?

Testing Instructions

  • Go to `/setup/site-migration?siteId={WPCOM_SITE_ID}&ref=wp-admin-importers-list
  • Go to next step
  • Click the UI back button 2 times
  • Check if you are on the importer list

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~15 bytes added 📈 [gzipped])

Details
name                        parsed_size           gzip_size
site-migration-flow               +81 B  (+0.2%)      +15 B  (+0.1%)
hosted-site-migration-flow        +81 B  (+0.2%)      +15 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires gabrielcaires requested a review from a team March 26, 2025 14:31
@gabrielcaires gabrielcaires self-assigned this Mar 26, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
@gabrielcaires gabrielcaires marked this pull request as ready for review March 26, 2025 14:31
@gabrielcaires gabrielcaires changed the title Redirect user back to import list based on the ref Site Migration: Redirect user back to import list based on the ref Mar 26, 2025
@gabrielcaires gabrielcaires merged commit 8748751 into trunk Mar 27, 2025
18 checks passed
@gabrielcaires gabrielcaires deleted the fix/back-button-from-import-list branch March 27, 2025 11:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants