HC: minor refactor and remove contact-form navigation#101898
HC: minor refactor and remove contact-form navigation#101898heavyweight merged 9 commits intotrunkfrom
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~47 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~49 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
You're only removing contact-form redirections for
The first time I clicked the downgrade button, I ran into the
The contact options are working correctly, Can we update the margin/padding on the spinner when the contact options are loading CleanShot.2025-03-27.at.09.20.44.mp4 |
I updated the spacing for the spinner. |
|
We should also disable the input field while loading the support interaction. |
alshakero
left a comment
There was a problem hiding this comment.
Code looks good. I tested all the places except migration error as I couldn't reach that code. I'm pretty sure it works great too.
Related to p1742409982270769-slack-C07D72S1135
Remove leftover redirects to
contact-form.Users creating chat from there will result in anonymous zd users using the Zendesk widget.
Proposed Changes
contact-form.contact-optionsare displayed.Why are these changes being made?
Testing Instructions
Testing Plan Downgrade Direct chat
/plans/{ site_slug }.User wants to downgrade planand the relevant siteSlug.Testing current chat guard
Testing fallback to
contact-optionsQuick regression test