Skip to content

Conversation

@vykes-mac
Copy link
Contributor

Closes #98845

Proposed Changes

  • Add a subtitle to the account creation page

Why are these changes being made?

Testing Instructions

  • Go to setup/onboarding/user and verify copy
  • Go to start/user-social and verify copy

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vykes-mac vykes-mac self-assigned this Mar 26, 2025
@github-actions
Copy link

github-actions bot commented Mar 26, 2025

@vykes-mac vykes-mac requested a review from a team March 26, 2025 22:26
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
@vykes-mac vykes-mac requested a review from fditrapani March 26, 2025 22:27
@vykes-mac vykes-mac added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Mar 26, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~22 bytes added 📈 [gzipped])

Details
name               parsed_size           gzip_size
stepper-user-step        +60 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~5 bytes added 📈 [gzipped])

Details
name                          parsed_size           gzip_size
async-load-signup-steps-user        +62 B  (+0.0%)       +5 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/account-creattion on your sandbox.

@fditrapani
Copy link
Contributor

This for working on this @vykes-mac! This tests well with the regular onboarding flow. When I saw your testing instructions, I wondered if there were any flows that aren't for creating sites. Do you know if there are any cases like that?

Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working as expected on both screens. Thanks @vykes-mac!

@autumnfjeld
Copy link
Contributor

@fditrapani @vykes-mac

This for working on this @vykes-mac! This tests well with the regular onboarding flow. When I saw your testing instructions, I wondered if there were any flows that aren't for creating sites. Do you know if there are any cases like that?

The domains flow has a the account screen , not for site creation.

https://www.awesomescreenshot.com/video/38130119?key=93c58cc559145f163e552601caf548cd

My opinion is to not add subtitle on the create account screen. The copy isn't suitable for hosting flows. Let's park this for now.

@fditrapani
Copy link
Contributor

Thanks for bringing that up @autumnfjeld. Let's leave it out for now. We can revisit this another time if it comes up.

@vykes-mac
Copy link
Contributor Author

Will not change at this point. See discussion

@vykes-mac vykes-mac closed this Mar 28, 2025
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Create account screen in goals first onboarding flow

6 participants