-
Notifications
You must be signed in to change notification settings - Fork 2k
Onboarding Copy Polish: Add account creation screen subtitle #101926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~22 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~5 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
This for working on this @vykes-mac! This tests well with the regular onboarding flow. When I saw your testing instructions, I wondered if there were any flows that aren't for creating sites. Do you know if there are any cases like that? |
paulopmt1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working as expected on both screens. Thanks @vykes-mac!
The domains flow has a the account screen , not for site creation. https://www.awesomescreenshot.com/video/38130119?key=93c58cc559145f163e552601caf548cd My opinion is to not add subtitle on the create account screen. The copy isn't suitable for hosting flows. Let's park this for now. |
|
Thanks for bringing that up @autumnfjeld. Let's leave it out for now. We can revisit this another time if it comes up. |
|
Will not change at this point. See discussion |
Closes #98845
Proposed Changes
Why are these changes being made?
Testing Instructions
setup/onboarding/userand verify copystart/user-socialand verify copyPre-merge Checklist