Plans Grid Next: add missing scss import#101952
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
8c42140 to
5b735fc
Compare
| { | ||
| "name": "@automattic/data-stores", | ||
| "version": "3.1.0", | ||
| "version": "3.1.1", |
There was a problem hiding this comment.
Why was the bump necessary? Did you release a new version and use it somewhere?
There was a problem hiding this comment.
Yes, I am working on using this package to render the pricing grid in Landpack. Here's my last update: pdvytD-130-p2#comment-864
I'll post a new update this week and will also tag you for visibility!
There was a problem hiding this comment.
I don't understand why we need to bump this package, though - are we consuming it directly? If not, won't it get built as a workspace dependency?
There was a problem hiding this comment.
We don't use this package directly, but it is a dependency for @automattic/plans-grid-next. When I install the latest version of @automattic/plans-grid-next in 175458-ghe-Automattic/wpcom, it will pull in all the dependencies for @automattic/plans-grid-next from npm. If we don't bump the version and publish the @automattic/data-stores package, it will just pull in the last published version, which is outdated and has missing functions.
I am not sure what the best practices are for updating code in packages. People do not usually bump versions and publish when they update a package, so whenever we need to use a package outside of Calypso, we need to bump+publish not just every package listed as a dependency but every package in the dependency tree. It would be nice to have a pre-push hook to ensure the committer updates the version whenever they update anything in packages/*. 🤔 What do you think?
Related to #
Proposed Changes
@automattic/data-storespackage.Testing Instructions
/setup/onboarding/plans.Pre-merge Checklist