Skip to content

Comments

Plans Grid Next: add missing scss import#101952

Merged
aneeshd16 merged 2 commits intotrunkfrom
update/plans-grid-next-scss-import
Mar 27, 2025
Merged

Plans Grid Next: add missing scss import#101952
aneeshd16 merged 2 commits intotrunkfrom
update/plans-grid-next-scss-import

Conversation

@aneeshd16
Copy link
Contributor

@aneeshd16 aneeshd16 commented Mar 27, 2025

Related to #

Proposed Changes

  • Adds a missing SCSS import. It is necessary to use this package outside of Calypso.
  • Bump the version for the @automattic/data-stores package.

Testing Instructions

  • Confirm that the plans grid renders correctly on /setup/onboarding/plans.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@aneeshd16 aneeshd16 requested a review from a team as a code owner March 27, 2025 11:06
@aneeshd16 aneeshd16 requested a review from oswian March 27, 2025 11:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
@github-actions
Copy link

github-actions bot commented Mar 27, 2025

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 27, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plans-grid-next-scss-import on your sandbox.

@aneeshd16 aneeshd16 force-pushed the update/plans-grid-next-scss-import branch from 8c42140 to 5b735fc Compare March 27, 2025 14:31
@aneeshd16 aneeshd16 merged commit 500e861 into trunk Mar 27, 2025
13 checks passed
@aneeshd16 aneeshd16 deleted the update/plans-grid-next-scss-import branch March 27, 2025 15:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
{
"name": "@automattic/data-stores",
"version": "3.1.0",
"version": "3.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the bump necessary? Did you release a new version and use it somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am working on using this package to render the pricing grid in Landpack. Here's my last update: pdvytD-130-p2#comment-864

I'll post a new update this week and will also tag you for visibility!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we need to bump this package, though - are we consuming it directly? If not, won't it get built as a workspace dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use this package directly, but it is a dependency for @automattic/plans-grid-next. When I install the latest version of @automattic/plans-grid-next in 175458-ghe-Automattic/wpcom, it will pull in all the dependencies for @automattic/plans-grid-next from npm. If we don't bump the version and publish the @automattic/data-stores package, it will just pull in the last published version, which is outdated and has missing functions.

I am not sure what the best practices are for updating code in packages. People do not usually bump versions and publish when they update a package, so whenever we need to use a package outside of Calypso, we need to bump+publish not just every package listed as a dependency but every package in the dependency tree. It would be nice to have a pre-push hook to ensure the committer updates the version whenever they update anything in packages/*. 🤔 What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants