Skip to content

Comments

Site Migration: Remove application-password feature flag#101959

Merged
gabrielcaires merged 2 commits intotrunkfrom
update/remove-application-password-feature-flag
Mar 27, 2025
Merged

Site Migration: Remove application-password feature flag#101959
gabrielcaires merged 2 commits intotrunkfrom
update/remove-application-password-feature-flag

Conversation

@gabrielcaires
Copy link
Contributor

Proposed Changes

  • Remove all code and references to the automated-migration/application-password feature flag

Why are these changes being made?

The feature was enabled 3 months ago with no issue.

Testing Instructions

  • Visual inspection should be enough

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 27, 2025

@gabrielcaires gabrielcaires marked this pull request as ready for review March 27, 2025 12:51
@gabrielcaires gabrielcaires requested a review from a team March 27, 2025 12:51
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
@gabrielcaires gabrielcaires self-assigned this Mar 27, 2025
@gabrielcaires gabrielcaires marked this pull request as draft March 27, 2025 12:55
@matticbot
Copy link
Contributor

matticbot commented Mar 27, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~39 bytes removed 📉 [gzipped])

Details
name                   parsed_size           gzip_size
entry-stepper               -342 B  (-0.0%)      -40 B  (-0.0%)
entry-subscriptions         -126 B  (-0.0%)      -21 B  (-0.0%)
entry-main                  -126 B  (-0.0%)      -20 B  (-0.0%)
entry-login                 -126 B  (-0.0%)      -21 B  (-0.0%)
entry-domains-landing       -126 B  (-0.0%)      -21 B  (-0.0%)
entry-browsehappy           -126 B  (-0.1%)      -21 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/remove-application-password-feature-flag on your sandbox.

@gabrielcaires gabrielcaires marked this pull request as ready for review March 27, 2025 13:26
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrielcaires gabrielcaires requested a review from a team as a code owner March 27, 2025 18:05
@gabrielcaires gabrielcaires force-pushed the update/remove-application-password-feature-flag branch from f2f1096 to dd56a3d Compare March 27, 2025 18:10
@gabrielcaires gabrielcaires merged commit af76ed1 into trunk Mar 27, 2025
13 checks passed
@gabrielcaires gabrielcaires deleted the update/remove-application-password-feature-flag branch March 27, 2025 18:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants