-
Notifications
You must be signed in to change notification settings - Fork 2k
Move payment method state to PaymentMethodProvider #101974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~89 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~89 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
…102074) CheckoutProvider does too much. Previous efforts have been made (#81796, #81793, #80529, #101974) to move toward making it just a wrapper for a series of other providers (perhaps eventually replacing it entirely?), but there's still state that it maintains. This PR moves all the state having to do with the list of payment processor functions to the PaymentMethodProvider, since payment processor functions are closely tied to payment method objects.
Proposed Changes
CheckoutProviderdoes too much. Previous efforts have been made (#81796, #81793, #80529) to move toward making it just a wrapper for a series of other providers (perhaps eventually replacing it entirely?), but there's still state that it maintains.This PR moves all the state having to do with the list of payment methods to a new provider,
PaymentMethodProvider.Testing Instructions
Automated tests should handle most things.