Skip to content

Comments

Onboarding: Fix the random flash of the domains step after onboarding flow#102026

Merged
arthur791004 merged 1 commit intotrunkfrom
fix/flash-domain-step-after-site-creation
Mar 28, 2025
Merged

Onboarding: Fix the random flash of the domains step after onboarding flow#102026
arthur791004 merged 1 commit intotrunkfrom
fix/flash-domain-step-after-site-creation

Conversation

@arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Mar 28, 2025

Related to p1743132194882019-slack-C08HKNPL2BG

Proposed Changes

  • Fix the random flash of the domains step after onboarding flow

Why are these changes being made?

  • Bad onboarding experience

Testing Instructions

  • Go to /sites
  • Create a new site
  • Ensure you won't see the domains step again after you finish the onboarding flow

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

@arthur791004 arthur791004 self-assigned this Mar 28, 2025
@arthur791004 arthur791004 requested a review from p-jackson March 28, 2025 05:56
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
@arthur791004 arthur791004 requested review from a team March 28, 2025 06:02
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~0 bytes added 📈 [gzipped])

Details
name             parsed_size           gzip_size
onboarding-flow        -13 B  (-0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/flash-domain-step-after-site-creation on your sandbox.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change makes sense 👍

@arthur791004 arthur791004 merged commit 0439f5c into trunk Mar 28, 2025
20 checks passed
@arthur791004 arthur791004 deleted the fix/flash-domain-step-after-site-creation branch March 28, 2025 06:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
@autumnfjeld
Copy link
Contributor

@zaerl This PR is a fix for a regression introduced in #100715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants