Skip to content

Comments

Revert "Revert "Stepper: Automated going back behaviour with non-linear flow support""#102028

Merged
alshakero merged 2 commits intotrunkfrom
revert-101907-revert-101550-fix/going-back
Mar 28, 2025
Merged

Revert "Revert "Stepper: Automated going back behaviour with non-linear flow support""#102028
alshakero merged 2 commits intotrunkfrom
revert-101907-revert-101550-fix/going-back

Conversation

@alshakero
Copy link
Member

@alshakero alshakero commented Mar 28, 2025

This reverts the revert because it turns out the original PR is not the culprit 🎢

Reverts #101907

Context: p1743133325078959/1743132194.882019-slack-C08HKNPL2BG

@alshakero alshakero requested a review from a team as a code owner March 28, 2025 08:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 28, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~35 bytes added 📈 [gzipped])

Details
name           parsed_size           gzip_size
entry-stepper       +182 B  (+0.0%)      +35 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~160 bytes removed 📉 [gzipped])

Details
name             parsed_size           gzip_size
onboarding-flow       -826 B  (-0.3%)     -160 B  (-0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-101907-revert-101550-fix/going-back on your sandbox.

@alshakero alshakero merged commit 09e0c18 into trunk Mar 28, 2025
13 checks passed
@alshakero alshakero deleted the revert-101907-revert-101550-fix/going-back branch March 28, 2025 13:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants