Skip to content

Comments

Self Service Downgrade: Remove email mention from lossless revert radio copy#102033

Merged
claudiucelfilip merged 1 commit intotrunkfrom
update/lossless-revert-radio-copy
Mar 28, 2025
Merged

Self Service Downgrade: Remove email mention from lossless revert radio copy#102033
claudiucelfilip merged 1 commit intotrunkfrom
update/lossless-revert-radio-copy

Conversation

@claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Mar 28, 2025

Related to 178675-ghe-Automattic/wpcom

Proposed Changes

Removes email mention in lossless revert text.

Why are these changes being made?

Copy for lossless reverts need to match reality.

Screenshot 2025-03-28 at 10 57 50

Testing Instructions

  • Go to purchases for an Atomic site
  • Go to Downgrade
  • The Restore my posts, pages, and media description shouldn't mention about recieving an email.
Screenshot 2025-03-28 at 10 56 46

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

@claudiucelfilip claudiucelfilip requested review from ddc22 and dzver March 28, 2025 09:44
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 28, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~17 bytes removed 📉 [gzipped])

Details
name            parsed_size           gzip_size
site-purchases        -41 B  (-0.0%)      -17 B  (-0.0%)
purchases             -41 B  (-0.0%)      -17 B  (-0.0%)
overview              -41 B  (-0.0%)      -17 B  (-0.0%)
domains               -41 B  (-0.0%)      -17 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@claudiucelfilip claudiucelfilip merged commit 3040851 into trunk Mar 28, 2025
18 of 20 checks passed
@claudiucelfilip claudiucelfilip deleted the update/lossless-revert-radio-copy branch March 28, 2025 09:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants