Skip to content

Conversation

@zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Mar 28, 2025

Why are these changes being made?

Consistency and ease of development.

Testing Instructions

No regressions compared to production should be introduced.

Test all steps in onboarding and site-setup, including user registration, and compare them to production.

Test that the loading component (in-between screens, before flow) is centered on the screen as well.

@zaguiini zaguiini requested a review from a team March 28, 2025 10:27
@zaguiini zaguiini self-assigned this Mar 28, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~108 bytes removed 📉 [gzipped])

Details
name                   parsed_size           gzip_size
entry-stepper               -392 B  (-0.0%)     -108 B  (-0.0%)
entry-subscriptions          -98 B  (-0.0%)       +7 B  (+0.0%)
entry-main                   -98 B  (-0.0%)       +7 B  (+0.0%)
entry-login                  -98 B  (-0.0%)       +7 B  (+0.0%)
entry-domains-landing        -98 B  (-0.0%)       +7 B  (+0.0%)
entry-browsehappy            -98 B  (-0.0%)       +7 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~96 bytes removed 📉 [gzipped])

Details
name                        parsed_size           gzip_size
signup                           -824 B  (-0.3%)      -24 B  (-0.0%)
async-step-unified-plans         -824 B  (-0.1%)      -23 B  (-0.0%)
async-step-unified-domains       -824 B  (-0.1%)      -21 B  (-0.0%)
checkout                         -128 B  (-0.0%)      -28 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~252 bytes removed 📉 [gzipped])

Details
name                                             parsed_size           gzip_size
async-load-signup-steps-domains                       -257 B  (-0.0%)     -105 B  (-0.1%)
async-load-signup-steps-plans-theme-preselected       -154 B  (-0.0%)      -57 B  (-0.0%)
async-load-signup-steps-plans                         -154 B  (-0.0%)      -62 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal       -128 B  (-0.0%)      -28 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug step-container-v2/use-gutenberg-breakpoints on your sandbox.

@zaguiini zaguiini marked this pull request as ready for review March 28, 2025 10:50
@zaguiini zaguiini requested a review from a team as a code owner March 28, 2025 10:50
@zaguiini zaguiini merged commit 07f3a43 into trunk Mar 28, 2025
18 checks passed
@zaguiini zaguiini deleted the step-container-v2/use-gutenberg-breakpoints branch March 28, 2025 10:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants