Skip to content

Retry when smooch init fails#102045

Merged
heavyweight merged 1 commit intotrunkfrom
fix/smooch-init-retry
Mar 28, 2025
Merged

Retry when smooch init fails#102045
heavyweight merged 1 commit intotrunkfrom
fix/smooch-init-retry

Conversation

@heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Mar 28, 2025

Proposed Changes

  • Retry if the smooch init call fails

Why are these changes being made?

  • Resilience

Testing Instructions

  • Checkout this PR
  • In Chrome dev tools block https://woothemes1654197491.z3nd3sk.com/sc/sdk/v2/apps/633dcb21690c2c00f4ca2eb8/login to simulate failure
  • Ensure that isChatLoaded is false
  • Ensure that the retry happens

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~36 bytes added 📈 [gzipped])

Details
name                                       parsed_size           gzip_size
async-load-automattic-help-center-stepper        +81 B  (+0.0%)      +36 B  (+0.0%)
async-load-automattic-help-center                +81 B  (+0.0%)      +36 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/smooch-init-retry on your sandbox.

@heavyweight heavyweight self-assigned this Mar 28, 2025
@heavyweight heavyweight marked this pull request as ready for review March 28, 2025 13:12
@heavyweight heavyweight requested a review from a team as a code owner March 28, 2025 13:12
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works great 👍

@heavyweight heavyweight merged commit 2dc36f8 into trunk Mar 28, 2025
19 checks passed
@heavyweight heavyweight deleted the fix/smooch-init-retry branch March 28, 2025 14:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments