[Site-Admin]: Add history@5.3.0 dependency (ARC-31)#102067
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
tyxla
left a comment
There was a problem hiding this comment.
The changes individually look good 👍
Might make sense to see how the package will be used, specifically with types, since I can see we still use an old version of @types/history as a dependency somewhere. With that in mind this could be part of a larger PR.
It seems that we don't need
|
|
That's correct - we don't need it, which is why we should keep an eye on where and how it's being used |
|
Here is where it is used. It doesn't look pretty well, btw 😀 |
Right. Would be nice if we could remove that hack. |
This PR adds the
historypackage dependency to the Site Admin package.Related to #
Proposed Changes
Why are these changes being made?
Testing Instructions
A visual review should be enough.
Pre-merge Checklist