Skip to content

Comments

Fix for locale suggestions links losing query string#102075

Merged
artpi merged 3 commits intotrunkfrom
locale_suggestions_fix
Mar 31, 2025
Merged

Fix for locale suggestions links losing query string#102075
artpi merged 3 commits intotrunkfrom
locale_suggestions_fix

Conversation

@artpi
Copy link
Contributor

@artpi artpi commented Mar 28, 2025

Fix for BSKY-202

When we have a localized flow, we are losing query string when switching to a different locale like suggested here. We are relying on this query string to pass along the prompt information.:

Zrzut ekranu 2025-03-28 o 17 59 52

Testing instructions

  1. Set your browser locale to NOT english
  2. Open incognito
  3. Go to http://calypso.localhost:3000/setup/ai-site-builder/user/?prompt=mariachi+restaurant
  4. Clcik the notice "change language to xyz"
  5. Observe query string being preserved
  6. Continue signup

@artpi artpi self-assigned this Mar 28, 2025
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 28, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4 bytes added 📈 [gzipped])

Details
name               parsed_size           gzip_size
stepper-user-step        +23 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 28, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug locale_suggestions_fix on your sandbox.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
@artpi artpi marked this pull request as ready for review March 28, 2025 17:22
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. Thanks!

artpi and others added 2 commits March 31, 2025 10:02
…tory/__user/index.tsx

Co-authored-by: Omar Alshaker <omar@omaralshaker.com>
@artpi artpi merged commit fb7e3a7 into trunk Mar 31, 2025
13 checks passed
@artpi artpi deleted the locale_suggestions_fix branch March 31, 2025 09:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants