Skip to content

Comments

Storybook: Expand controls by default#102105

Merged
mirka merged 1 commit intotrunkfrom
storybook-expand-controls
Apr 1, 2025
Merged

Storybook: Expand controls by default#102105
mirka merged 1 commit intotrunkfrom
storybook-expand-controls

Conversation

@mirka
Copy link
Member

@mirka mirka commented Mar 28, 2025

Closes ARC-37

Proposed Changes

Expands the Storybook controls by default so the prop descriptions can always be read.

Before After
Story controls, before Story controls, after

Why are these changes being made?

This will be increasingly useful as we improve are props documentation.

Testing Instructions

yarn components:storybook:start and see the individual story pages (not Docs) for the Calendar component.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 28, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug storybook-expand-controls on your sandbox.

@mirka mirka force-pushed the storybook-expand-controls branch from bf97e55 to b22776c Compare March 31, 2025 16:53
@mirka mirka requested a review from a team March 31, 2025 21:40
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 31, 2025
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mirka mirka merged commit acb118f into trunk Apr 1, 2025
13 of 15 checks passed
@mirka mirka deleted the storybook-expand-controls branch April 1, 2025 14:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 1, 2025
JessBoctor pushed a commit to JessBoctor/wp-calypso that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants