Skip to content

Remove unused state variable#102116

Merged
CodeyGuyDylan merged 1 commit intotrunkfrom
remove/unused-state-variable
Mar 31, 2025
Merged

Remove unused state variable#102116
CodeyGuyDylan merged 1 commit intotrunkfrom
remove/unused-state-variable

Conversation

@CodeyGuyDylan
Copy link
Contributor

Proposed Changes

  • Remove unused variable added here

Why are these changes being made?

An unused variable got shipped in a PR mistakenly

Testing Instructions

N/A

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 29, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/unused-state-variable on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~28 bytes removed 📉 [gzipped])

Details
name         parsed_size           gzip_size
entry-login        -96 B  (-0.0%)      -28 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@CodeyGuyDylan CodeyGuyDylan merged commit 3347b8a into trunk Mar 31, 2025
14 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the remove/unused-state-variable branch March 31, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants