-
Notifications
You must be signed in to change notification settings - Fork 2k
[Site Admin]: Add NavigableRegion component #102361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Ah, bummer we're duplicating yet another existing component. I wish we could just use the one from |
|
AFAIK, it's a private component |
|
The plan is to get everything ready so we can switch to the core one as soon as it becomes public |
|
I don't see an alternative, given that the component is not exported from Although I'm slightly confused by this sentence:
I was under the impression that the goal for the If that's the case, switching to core as soon as it becomes public may not be possible as our version may have diverged signifcantly. |
65761e1 to
5532b9d
Compare
Yes, that makes sense. But if, for any reason, core exposes resources that are copies of them — like the router package, for instance — we can switch to those instead. |
packages/site-admin/src/interface/components/navigable-region/index.tsx
Outdated
Show resolved
Hide resolved
packages/site-admin/src/interface/components/navigable-region/index.tsx
Outdated
Show resolved
Hide resolved
5532b9d to
e6dd1ab
Compare
ciampo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, given that I won't be very responsive for the rest of the week.
Feel free to merge after addressing #102361 (comment)
d69b732 to
93cf99b
Compare
Create new component for accessible keyboard navigation regions with ARIA support
This className is not used for now. We can add it in follow-ups if it's required.
…index.tsx Co-authored-by: Marco Ciampini <marco.ciampini@automattic.com>
f5b65e3 to
052d87e
Compare
* Introduce first approach of NavigableRegion cmp Create new component for accessible keyboard navigation regions with ARIA support * improve NavigableRegion component types * add JSDoc to NavigableRegion component * changelog * reorganize interface cmps - expose NavigableRegion cpm * remove component className This className is not used for now. We can add it in follow-ups if it's required. * Update NavigableRegion export to named export * fix changelog tracks * Update packages/site-admin/src/interface/components/navigable-region/index.tsx Co-authored-by: Marco Ciampini <marco.ciampini@automattic.com> --------- Co-authored-by: Marco Ciampini <marco.ciampini@automattic.com>
* Introduce first approach of NavigableRegion cmp Create new component for accessible keyboard navigation regions with ARIA support * improve NavigableRegion component types * add JSDoc to NavigableRegion component * changelog * reorganize interface cmps - expose NavigableRegion cpm * remove component className This className is not used for now. We can add it in follow-ups if it's required. * Update NavigableRegion export to named export * fix changelog tracks * Update packages/site-admin/src/interface/components/navigable-region/index.tsx Co-authored-by: Marco Ciampini <marco.ciampini@automattic.com> --------- Co-authored-by: Marco Ciampini <marco.ciampini@automattic.com>
Introduces a new
<NavigableRegion />component that creates accessible regions with keyboard navigation support.This component follows Gutenberg's pattern for creating navigable sections in the admin interface, providing proper ARIA attributes and keyboard interaction capabilities.
The component is flexible, allowing different HTML elements via the
asprop while maintaining consistent accessibility features across the interface.Related to ARC-27
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist