-
Notifications
You must be signed in to change notification settings - Fork 2k
Magic Link: refactor Jetpack loading indicator to use Spinner component #102406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Replace LoadingEllipsis with Spinner for a more consistent loading experience. * Update corresponding styles to reflect the new loading spinner design.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~19 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
| "jetpack/features-section/atomic": true, | ||
| "jetpack/features-section/jetpack": true, | ||
| "jetpack/features-section/simple": true, | ||
| "jetpack/magic-link-signup": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature flag enables the magic link signup, and it was already enabled on all environments (production, stage, development, horizon), except wpcalypso, which is the one on Calypso Live Branches.
grzegorz-cp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…nt (Automattic#102406) * Refactor loading indicator in magic login form to use Spinner component * Replace LoadingEllipsis with Spinner for a more consistent loading experience. * Update corresponding styles to reflect the new loading spinner design. * Enable jetpack/magic-link-signup feature on wpcalypso * Add margin-top to magic login button for improved spacing
…nt (Automattic#102406) * Refactor loading indicator in magic login form to use Spinner component * Replace LoadingEllipsis with Spinner for a more consistent loading experience. * Update corresponding styles to reflect the new loading spinner design. * Enable jetpack/magic-link-signup feature on wpcalypso * Add margin-top to magic login button for improved spacing
Fixes MARTECH-70
Proposed Changes
LoadingEllipsiswith coreSpinnercomponent for a more consistent loading experience.jetpack/magic-link-signupon Live Branches environment, so this PR could be tested there. This is a legacy feature flag that was available on all environment exceptwpcalypso.CleanShot.2025-04-04.at.20.47.08.2.mp4
CleanShot.2025-04-04.at.20.46.38.mp4
Why are these changes being made?
We want to improve the Jetpack Onboarding experience.
Testing Instructions
/wp-admin/admin.php?page=my-jetpack&step=onboardingon the site.CleanShot.2025-04-04.at.22.05.16-converted.2.mp4
Pre-merge Checklist