Skip to content

Conversation

@Initsogar
Copy link
Contributor

@Initsogar Initsogar commented Apr 5, 2025

Fixes MARTECH-70

Proposed Changes

  • Replace LoadingEllipsis with core Spinner component for a more consistent loading experience.
  • Update corresponding styles to reflect the new loading spinner design.
  • Enable jetpack/magic-link-signup on Live Branches environment, so this PR could be tested there. This is a legacy feature flag that was available on all environment except wpcalypso.
Before After
CleanShot.2025-04-04.at.20.47.08.2.mp4
CleanShot.2025-04-04.at.20.46.38.mp4

Why are these changes being made?

We want to improve the Jetpack Onboarding experience.

Testing Instructions

  1. Spin up a Calypso Live Branch (you will need it on step 6).
  2. Spin up a Jurassic Ninja site using the latest Jetpack.
  3. Go to /wp-admin/admin.php?page=my-jetpack&step=onboarding on the site.
  4. Fill out your email and submit the form.
  5. You should be redirected to the magic link page, where you receive the login e-mail.
  6. On that page, replace the domain from wordpress.com to your Calypso Live Branch domain and navigate there.
  7. Ensure the loading state uses the spinner instead of the ellipsis.
CleanShot.2025-04-04.at.22.05.16-converted.2.mp4

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

* Replace LoadingEllipsis with Spinner for a more consistent loading experience.
* Update corresponding styles to reflect the new loading spinner design.
@Initsogar Initsogar self-assigned this Apr 5, 2025
@github-actions
Copy link

github-actions bot commented Apr 5, 2025

@matticbot
Copy link
Contributor

matticbot commented Apr 5, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~19 bytes added 📈 [gzipped])

Details
name         parsed_size           gzip_size
entry-login        +76 B  (+0.0%)      +19 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Apr 5, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/jetpack-onboarding-loading-spinner on your sandbox.

@Initsogar Initsogar changed the title Jetpack Onboarding: refactor loading indicator in magic login form to use Spinner component Magic Link: refactor Jetpack loading indicator to use Spinner component Apr 5, 2025
@Initsogar Initsogar requested review from grzegorz-cp and keoshi April 5, 2025 03:08
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 5, 2025
@Initsogar Initsogar marked this pull request as ready for review April 5, 2025 03:08
"jetpack/features-section/atomic": true,
"jetpack/features-section/jetpack": true,
"jetpack/features-section/simple": true,
"jetpack/magic-link-signup": true,
Copy link
Contributor Author

@Initsogar Initsogar Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature flag enables the magic link signup, and it was already enabled on all environments (production, stage, development, horizon), except wpcalypso, which is the one on Calypso Live Branches.

Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grzegorz-cp grzegorz-cp merged commit b9af617 into trunk Apr 7, 2025
18 of 19 checks passed
@grzegorz-cp grzegorz-cp deleted the update/jetpack-onboarding-loading-spinner branch April 7, 2025 05:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 7, 2025
JessBoctor pushed a commit to JessBoctor/wp-calypso that referenced this pull request Apr 15, 2025
…nt (Automattic#102406)

* Refactor loading indicator in magic login form to use Spinner component

* Replace LoadingEllipsis with Spinner for a more consistent loading experience.
* Update corresponding styles to reflect the new loading spinner design.

* Enable jetpack/magic-link-signup feature on wpcalypso

* Add margin-top to magic login button for improved spacing
JessBoctor pushed a commit to JessBoctor/wp-calypso that referenced this pull request Apr 17, 2025
…nt (Automattic#102406)

* Refactor loading indicator in magic login form to use Spinner component

* Replace LoadingEllipsis with Spinner for a more consistent loading experience.
* Update corresponding styles to reflect the new loading spinner design.

* Enable jetpack/magic-link-signup feature on wpcalypso

* Add margin-top to magic login button for improved spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants