Remove unused createWithBigSky from onboard datastore

[ciampo]

Related to #101759
Related to DOTOBRD-36
Extracted from #101921

Proposed Changes

Remove unused createWithBigSky from onboard datastore

Why are these changes being made?

With the removal of goals-first onboarding (see #101759 (comment)) , I realized that setCreateWithBigSky action is only called once, with false — meaning that we can clean up all usages of getCreateWithBigSky, assuming that it will always return false (and we can clean up the data-store too).

Testing Instructions

• Make sure the createWithBigSky data from the onboard data store is never set to anything different than false
• Make sure that code changes make sense and that there are no leftover usages
• Smoke test the affected files (mostly the plans overview and the upsell modal), make sure that they behave exactly as on trunk

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-140535

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-140535&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-140535&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/set-create-with-big-sky on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~54 bytes removed 📉 [gzipped])

Details

name           parsed_size           gzip_size
entry-stepper       -276 B  (-0.0%)      -35 B  (-0.0%)
entry-main           -99 B  (-0.0%)       -5 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~63 bytes added 📈 [gzipped])

Details

name                      parsed_size            gzip_size
jetpack-app                  -44073 B  (-10.8%)   -12152 B  (-9.5%)
plugins                      -43043 B   (-1.3%)   -11768 B  (-1.3%)
plans                        -40582 B   (-1.9%)   -10818 B  (-1.8%)
async-step-unified-plans       -763 B   (-0.1%)     -184 B  (-0.1%)
a8c-for-agencies-client        -289 B   (-0.0%)      -45 B  (-0.0%)
site-settings                  -276 B   (-0.0%)      -47 B  (-0.0%)
settings                       -276 B   (-0.0%)      -21 B  (-0.0%)
hosting                        -276 B   (-0.0%)      -47 B  (-0.0%)
home                           -276 B   (-0.0%)      -58 B  (-0.0%)
checkout                       -276 B   (-0.0%)      -41 B  (-0.0%)
subscribers                    -263 B   (-0.0%)      -62 B  (-0.0%)
overview                        -13 B   (-0.0%)      +52 B  (+0.0%)
domains                         -13 B   (-0.0%)      +52 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~155 bytes added 📈 [gzipped])

Details

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected      -1039 B  (-0.2%)     -210 B  (-0.1%)
async-load-signup-steps-plans                        -1039 B  (-0.2%)     -203 B  (-0.1%)
async-load-signup-steps-domains                       -276 B  (-0.0%)      -73 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal       -276 B  (-0.0%)      -34 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[Copilot]

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

client/my-sites/plans-features-main/components/plan-upsell-modal/paid-plan-is-required-dialog.tsx:31

• The removal of createWithBigSky conditions alters the modal messaging logic; please confirm that the new default messaging aligns with the intended user experience.

if ( createWithBigSky && paidDomainName ) { return translate( 'Domains and our AI Website Builder are only available with a paid plan' ); }

client/my-sites/plans-features-main/components/plan-upsell-modal/hooks/use-modal-resolution-callback.tsx:47

• By removing this branch, modal resolution may handle certain onboarding flows differently; ensure this change is fully consistent with the updated business logic.

if ( createWithBigSky && ONBOARDING_FLOW === flowName ) { return PAID_PLAN_IS_REQUIRED_DIALOG; }

[p-jackson]

Yes this is exactly right thanks @ciampo
The createWithBigSky state was necessary for the goals-first onboarding flow because we needed to know how it was the user had arrived at the plans step. The goals-step is no more, so the state is no longer used.