Skip to content

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Apr 7, 2025

Related to #100270 (comment).

Proposed Changes

  • introduce a new Transfer domain link to the Active domains card:

Markup on 2025-04-08 at 11:15:11

Why are these changes being made?

This change is first of the updates outlined in #100270 (comment).

Testing Instructions

  1. Check out the branch PR and build the app with yarn start (or use the Calypso Live link).
  2. Head over to http://calypso.localhost:3000/overview/{site-slug} and scroll down to the Active domains card.
  3. There should be a new Transfer domain button that should lead to the flow of transferring a an existing domain from elsewhere to WordPress.com.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger self-assigned this Apr 7, 2025
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/transfer-domain-button-to-active-domains-card on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes added 📈 [gzipped])

Details
name      parsed_size           gzip_size
overview       +218 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ivan-ottinger ivan-ottinger marked this pull request as ready for review April 8, 2025 09:20
@ivan-ottinger ivan-ottinger requested a review from a team April 8, 2025 09:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 8, 2025
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and work as described. 🚀

The new option is rendered as expected, and clicking it takes me to /domains/add/use-my-domain/:siteId?redirect_to=/overview/:siteId
image

@ivan-ottinger
Copy link
Contributor Author

Thank you for your review and testing, Gergely!

@ivan-ottinger ivan-ottinger merged commit 03f2798 into trunk Apr 9, 2025
18 checks passed
@ivan-ottinger ivan-ottinger deleted the add/transfer-domain-button-to-active-domains-card branch April 9, 2025 10:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants