Subscribers: Enable the subscriptions library flag in all environments

[allilevine]

Proposed Changes

• Enable the feature flag in all environments to launch the library for /subscribers.

Why are these changes being made?

• Performance and scalability.

Testing Instructions

• Go to /subscribers/{site url}
• Smoke test:
  • The subscribers load without console or network errors.
  • The correct data displays in the table.
  • You can sort by all sortable columns.
  • You can filter by all filters.
  • You can combine filters.
  • You can click on a subscriber and see the correct URL and details.
  • Pagination works correctly.
  • Import new subscriber(s) and check there's no lag in updating the list.
  • Remove new subscriber(s) and check there's no lag in updating the list.
  • Export subscribers.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141336

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141336&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141336&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~44 bytes added 📈 [gzipped])

Details

name         parsed_size           gzip_size
subscribers       +110 B  (+0.0%)      +44 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~24 bytes added 📈 [gzipped])

Details

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-subscribers       +202 B  (+0.1%)      +24 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/subscriptions-library-all-envs on your sandbox.

[Addison-Stavlo]

I may be a bit confused on the context and testing. This seems to be enabling the flag for the subscribers library on various environments including production, staging, horizon, and more, but when I test this I am not seeing any differences from what already exists on /subscribers/{siteUrl}.

[allilevine]

I may be a bit confused on the context and testing. This seems to be enabling the flag for the subscribers library on various environments including production, staging, horizon, and more, but when I test this I am not seeing any differences from what already exists on /subscribers/{siteUrl}.

@Addison-Stavlo That's correct, there should be no difference. The flag enables a few different front-end changes to how we pull and read the subscriber data, and I want to make sure I'm not introducing any bugs. This post has context: pe7F0s-2Fy-p2

I'm planning to ship this and then monitor performance, make sure there's no unexpected spikes or anything.

[mehmoodak]

Smoke tested following list, all of these things are working as expected.

    - The subscribers load without console or network errors.
    - The correct data displays in the table.
    - You can sort by all sortable columns.
    - You can filter by all filters.
    - You can combine filters.
    - You can click on a subscriber and see the correct URL and details.
    - Pagination works correctly.
    - Import new subscriber(s) and check there's no lag in updating the list.
    - Remove new subscriber(s) and check there's no lag in updating the list. 
    - Export subscribers.

[allilevine]

I found a bug and pushed a fix: 044f6fd

Categories weren't loading on the details pages because of a mismatch in subscriber id terminology. The details were also loading twice, so I changed the categories hook call to use the subscriber id directly, vs. using selectedSubscriber.