Skip to content

Conversation

@jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented May 23, 2025

Removes a feature flag that is always-on in all environments. Both Calypso Blue and Calypso Green.

@jsnajdr jsnajdr requested review from a team and manzoorwanijk May 23, 2025 14:19
@jsnajdr jsnajdr self-assigned this May 23, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 23, 2025
@github-actions
Copy link

github-actions bot commented May 23, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/jetpack-social-plans-v1-flag on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~129 bytes removed 📉 [gzipped])

Details
name                   parsed_size           gzip_size
plans                       -558 B  (-0.0%)     -129 B  (-0.0%)
jetpack-connect             -558 B  (-0.0%)     -129 B  (-0.0%)
jetpack-cloud-pricing       -558 B  (-0.1%)     -129 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to do it the other day but had to deal with some tasks with higher priority than this clean up. Thank you for doing this.

@jsnajdr jsnajdr merged commit 67fe797 into trunk May 26, 2025
13 of 14 checks passed
@jsnajdr jsnajdr deleted the remove/jetpack-social-plans-v1-flag branch May 26, 2025 06:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants