Skip to content

chore(deps): update dependency typescript to v5.8.2#88826

Merged
jsnajdr merged 2 commits intotrunkfrom
renovate/typescript-related-packages
Mar 25, 2025
Merged

chore(deps): update dependency typescript to v5.8.2#88826
jsnajdr merged 2 commits intotrunkfrom
renovate/typescript-related-packages

Conversation

@matticbot
Copy link
Contributor

@matticbot matticbot commented Mar 23, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) ^5.6.3 -> ^5.8.2 age adoption passing confidence
typescript (source) 5.6.3 -> 5.8.2 age adoption passing confidence

Release Notes

microsoft/TypeScript (typescript)

v5.8.2: TypeScript 5.8

Compare Source

For release notes, check out the release announcement.

Downloads are available on:

v5.7.3: TypeScript 5.7.3

Compare Source

For release notes, check out the release announcement.

Downloads are available on npm

v5.7.2: TypeScript 5.7

Compare Source

For release notes, check out the release announcement.

Downloads are available on:


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@matticbot matticbot requested review from a team as code owners March 23, 2024 00:12
@matticbot matticbot added [Type] Task dependencies Pull requests that update a dependency file Framework labels Mar 23, 2024
@matticbot matticbot requested review from a team, ddc22 and samacart and removed request for a team March 23, 2024 00:12
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 23, 2024
@github-actions
Copy link

github-actions bot commented Mar 23, 2024

@matticbot
Copy link
Contributor Author

matticbot commented Mar 23, 2024

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot matticbot force-pushed the renovate/typescript-related-packages branch 3 times, most recently from 2a0db04 to c0b86f4 Compare March 30, 2024 19:34
@matticbot matticbot changed the title chore(deps): update dependency typescript to ^5.4.2 chore(deps): update dependency typescript to ^5.4.3 Mar 30, 2024
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch from c0b86f4 to 21c4961 Compare April 14, 2024 19:15
@matticbot matticbot changed the title chore(deps): update dependency typescript to ^5.4.3 chore(deps): update dependency typescript to ^5.4.4 Apr 14, 2024
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch 3 times, most recently from f92fac0 to c1e4bbb Compare April 20, 2024 14:40
@matticbot matticbot changed the title chore(deps): update dependency typescript to ^5.4.4 chore(deps): update dependency typescript to ^5.4.5 Apr 20, 2024
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch 2 times, most recently from 7d40b14 to 2289019 Compare April 22, 2024 12:08
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch 2 times, most recently from 06f54ba to e1c2c3d Compare May 8, 2024 11:35
@xavier-lc xavier-lc force-pushed the renovate/typescript-related-packages branch from d535b1c to 55682d2 Compare March 10, 2025 09:09
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch from 55682d2 to 345bd2f Compare March 13, 2025 06:41
@matticbot matticbot changed the title chore(deps): update dependency typescript to ^5.7.3 chore(deps): update dependency typescript to v5.8.2 Mar 13, 2025
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch 6 times, most recently from 8e503d2 to 1eea389 Compare March 19, 2025 02:32
@taipeicoder
Copy link
Contributor

taipeicoder commented Mar 19, 2025

The following failure happens when updating to TypeScript 5.6.2

Screenshot 2025-03-19 at 11 38 30 AM

Updating to TypeScript 5.6.0-beta results in the same error. This can be solved by adding "@types/node": "^22.7.5" to /packages/components/package.json as devDependency.

That said, we probably also need to update typescript-eslint to 8.10.0 so that it supports TypeScript 5.6.

@jsnajdr
Copy link
Member

jsnajdr commented Mar 19, 2025

The following failure happens when updating to TypeScript 5.6.2

That's because the version of @types/node in packages/components is old, it's version 18.8.9. It's there because Storybook 7 depends on it explicitly. Rest of the repo depends on @types/node in the root node_modules, and there it's 22.10.10.

The difference between them is the signature of the ImportMeta.resolve function. In old versions it's optional (resolve?()), in the new version the ? optionality is no longer there.

A good solution that could work: edit packages/components/package.json and add @types/node: 22 dependency explicitly. Currently the v18 version is used by the entire components package, not just by Storybook, and that probably causes the errors.

Other Calypso packages like calypso-color-schemes or calypso-config already have this explicit dependency.

@taipeicoder
Copy link
Contributor

taipeicoder commented Mar 20, 2025

Yup, adding "@types/node": "^22.7.5" to /packages/components/package.json as devDependency solves that problem. After fixing some TS errors there's the next group of compatibility issues:

Screenshot 2025-03-20 at 10 30 33 AM

Edit: proposing #101590 to update TS to 5.6.2.

@taipeicoder taipeicoder mentioned this pull request Mar 20, 2025
8 tasks
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch from 1eea389 to eb2a757 Compare March 21, 2025 02:32
@taipeicoder taipeicoder mentioned this pull request Mar 21, 2025
8 tasks
@matticbot matticbot force-pushed the renovate/typescript-related-packages branch from eb2a757 to 3aba282 Compare March 21, 2025 04:07
@taipeicoder
Copy link
Contributor

FWIW, updating TypeScript to 5.7.2 results in the following error:

Screenshot 2025-03-21 at 12 52 39 PM

@jsnajdr
Copy link
Member

jsnajdr commented Mar 24, 2025

The "Debug Failure. False expression" error is reported here: microsoft/TypeScript#52952 Probably a TS bug. I'm trying to figure out what it means and where it comes from 🙂

@jsnajdr
Copy link
Member

jsnajdr commented Mar 24, 2025

Fixed the "debug failure" error by removing unused and breaking file client/lib/shims/json.js. See microsoft/TypeScript#52952 (comment) and the replies to see why export default JSON is breaking.

Fortunately for us it turns out that file was unused 🙂

@matticbot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@jsnajdr jsnajdr force-pushed the renovate/typescript-related-packages branch from 8f14ce5 to a0b1b94 Compare March 24, 2025 21:23
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and CI checks are also green after recent changes ✅

@taipeicoder
Copy link
Contributor

Awesome sleuthing! @Automattic/vertex this should be good to merge.

@jsnajdr jsnajdr merged commit d2ebe1f into trunk Mar 25, 2025
13 checks passed
@jsnajdr jsnajdr deleted the renovate/typescript-related-packages branch March 25, 2025 08:27
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 25, 2025
claudiucelfilip pushed a commit that referenced this pull request Mar 25, 2025
* chore(deps): update dependency typescript to v5.8.2

* Remove unused (and TS-breaking) lib/shims

---------

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jarda Snajdr <jsnajdr@gmail.com>
Co-authored-by: taipeicoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Framework [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments