Added tests for tables command and testing docs #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekn
approved these changes
Nov 27, 2024
Contributor
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
Thanks for documenting tests!
| The test cases depend on real WordPress installations, meaning the usual PHP and MySQL dependencies are required. However, we can opt to use SQLite instead of MySQL to make running the tests locally easier. Here's how to run the full test suite with a SQLite database: | ||
|
|
||
| ``` | ||
| WP_CLI_TEST_DBTYPE=sqlite vendor/bin/behat |
Contributor
There was a problem hiding this comment.
Nice! I missed that before, and I was running those tests by providing a path to MySQL.
Contributor
Author
|
It doesn't look like we run these tests with CI 🤔 I'll take a quick look at that, too, but I might submit a fix separately |
This reverts commit 96aeaad.
Contributor
Author
|
It looks like the Testing workflow had been automatically disabled because Github does that when a repo has been inactive for N days, and the action uses a cron schedule (which this action did). I assume we'll be using pull requests to push new code to this repo at this point, meaning I don't see a clear point in running that workflow on a cron schedule. I removed the cron schedule to prevent the same thing from happening again. |
This reverts commit 6de86ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/dotcom-forge/issues/9976
Following up from #5, this PR adds two Behat tests for the
wp sqlite tablescommand.Because I wasn't previously familiar with Behat, I also took the opportunity to add some rudimentary docs.