Align agent-task-contracts test to DM-free default substrate#1633
Merged
Conversation
The generic agent-task recipe no longer mounts data-machine or data-machine-code by default; the default runtime substrate is now agents-api (when resolvable) plus the bundled wp-codebox plugin only. The genericRecipe assertions still expected Data Machine / Data Machine Code in extra_plugins, component_manifest.components, and the runtime-component-contracts arg, turning CI red on main. Flip those genericRecipe default-substrate assertions to assert absence. The explicit-propagation recipe below still passes data-machine and data-machine-code via component_contracts and still asserts they are provisioned, so explicit caller propagation remains covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a stale test that was red on
main. The generic agent-task recipe (packages/runtime-core/src/agent-task-recipe.ts,defaultRuntimeComponentSources()) no longer mountsdata-machineordata-machine-codeby default — the default runtime substrate is nowagents-api(when resolvable) plus the bundledwordpress-plugin(wp-codebox) only. The external coding-agent plugin is no longer mounted by default.tests/agent-task-contracts.test.tsstill asserted, against thegenericRecipe(built with no Data Machine inputs, relying on the default substrate), thatdata-machine/data-machine-codeappeared inextra_plugins,component_manifest.components, and theruntime-component-contracts-jsonstep arg. Those assertions now fail.Changes
Only
tests/agent-task-contracts.test.ts, only thegenericRecipedefault-substrate assertions:extra_pluginscontainsdata-machine/data-machine-code:true→falsecomponent_manifest.componentscontainsdata-machine/data-machine-code:true→falseruntime-component-contracts-jsonarg containsdata-machine/data-machine-code:true→falseThe existing positive assertions (
agents-apiandwordpress-pluginpresent) are unchanged. The separate explicit-propagation recipe below still passesdata-machine/data-machine-codeviacomponent_contractsand still asserts they ARE provisioned — explicit caller propagation remains fully covered, so this is not a weakening to a no-op.This aligns the test to merged intent (DM-free default substrate per the code comment and native-runtime direction), not masking a regression.
Test
Confirmed red before the change (
actual: false, expected: true) and green after. Adjacent recipe tests (test:recipe-validation-descriptors,test:host-recipe-builder) also pass.AI assistance
agent-task-contractstest to the DM-free default substrate.