Remove legacy contract compatibility#1637
Merged
Merged
Conversation
…recipe-command # Conflicts: # tests/agent-task-contracts.test.ts
chubes4
added a commit
to Extra-Chill/homeboy-extensions
that referenced
this pull request
Jun 29, 2026
…t loader (#2023) The wp-codebox runtime contract loader validated every manifest against a REQUIRED_RUNTIME_CONTRACT_PATHS list that still demanded schemas.agentTask.legacyRunResponse. Automattic/wp-codebox#1637 ("Remove legacy contract compatibility") dropped that legacy alias from the canonical runtime-core manifest, so loadCanonicalRuntimeContractSourceSync now throws "WP Codebox canonical runtime contract manifest is unavailable" for every real run -- the module loads fine and exposes runtimeContractManifest, but validation fails on the missing legacy path. This regressed the runtime-agent-full-run "Build runner config" step against the real built dist/contracts.js. The module load and require/import interop are correct; the loader was simply requiring a path the canonical contract intentionally stopped publishing. Drop the obsolete required path so the loader tracks the canonical manifest. The legacy alias only duplicated schemas.agentTask.runResult, which is still required. The unit smoke fixture carried the same stale legacyRunResponse alias, which is why homeboy-extensions CI stayed green while every downstream run broke. Align the smoke fixture with the canonical (legacy-free) manifest, assert the loader no longer demands the removed path, and add a wp-codebox-test-runtime-canary step that loads the manifest through the runner's own loader against the REAL built runtime-core module so future canonical-contract drift fails here instead of in every consumer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
AI assistance