Fix: check for valid secret only when creating a release build#486
Merged
Conversation
ockham
approved these changes
Aug 6, 2018
Contributor
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
Thanks for fixing so quickly! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In #467 the secrets check has been simplified which leads to an error when not using the official wp.com client id.
This PR is changing the secrets check to fail only when
CONFIG_ENVisreleaseand the secret is not the official wp.com client id.How to test:
calypso/config/secrets.jsonchangedesktop_oauth_client_idto eg.12345.make build CONFIG_ENV=releaseand the build should fail.desktop_oauth_client_idto43452.make build CONFIG_ENV=releaseand the build should succeed.Motivation and Context:
This PR closes #483