52 av dev up to date#126
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR appears to be a major restructuring effort that removes significant portions of the codebase from the repository. The title "52 av dev up to date" suggests this is syncing changes from a dev branch.
Key changes:
- Deletion of the entire Portal project (backend, database, and web UI)
- Deletion of all Shared libraries (SharpEngine.Shared, SharpEngine.Rest, SharpEngine.Identity, sharpengine-ui-shared)
- Removal of multiple Launcher UI components and styles
- Update of project references in the solution file to point to an external SharpEngine-Shared directory
- Addition of badges to README.md (some with placeholders)
Reviewed changes
Copilot reviewed 252 out of 277 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Engine/SharpEngine.slnx | Updated project references to point to external SharpEngine-Shared directory (../../) |
| README.md | Added new badges including NuGet downloads (with placeholder), launcher description |
| Shared/* | Complete removal of all shared libraries and UI components |
| Portal/* | Complete removal of Portal backend, database, and frontend projects |
| Engine/Launcher/* | Removal of various UI components, styles, and configuration files |
Critical Issues:
- The external project references may cause build failures if the directory structure isn't consistent across all environments
- The PR description is incomplete (all TBDs), providing no context for these major deletions
- A placeholder ("PACKAGE_NAME") remains in the README badge that needs to be replaced
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Project Path="../../SharpEngine-Shared/SharpEngine.Rest/SharpEngine.Rest.csproj"> | ||
| <BuildType Solution="LauncherNonWindows|*" Project="Release" /> | ||
| </Project> | ||
| <Project Path="../Shared/SharpEngine.Shared/SharpEngine.Shared.csproj"> | ||
| <Project Path="../../SharpEngine-Shared/SharpEngine.Shared/SharpEngine.Shared.csproj"> | ||
| <BuildType Solution="LauncherNonWindows|*" Project="Release" /> | ||
| </Project> |
There was a problem hiding this comment.
The project paths have been changed from ../Shared/ to ../../SharpEngine-Shared/, indicating that the shared projects have been moved to a different repository or directory structure. However, these paths point outside the current repository (../../), which suggests they're referencing an external location. This could cause build failures if the SharpEngine-Shared directory doesn't exist at that relative path on all development machines. Consider documenting this dependency structure or using a more robust reference mechanism like Git submodules or NuGet packages.
| <div align="center"> | ||
|
|
||
| [](https://www.nuget.org/packages/SharpEngine.Core.NET) | ||
|  |
There was a problem hiding this comment.
The placeholder text "PACKAGE_NAME" in the NuGet Downloads badge needs to be replaced with the actual package name. This badge will not function correctly until the placeholder is updated.
| <div align="center"> | ||
|
|
||
| [](https://www.nuget.org/packages/SharpEngine.Core.NET) | ||
|  |
There was a problem hiding this comment.
The PR description contains only "TBD" placeholders with no actual description of what changes are being made. Given the massive scope of this PR (deletion of entire Portal and Shared directories), this lacks critical information about why these deletions are occurring, whether they're intentional, and what the migration strategy is. The PR should be updated with a proper description explaining the restructuring.



<Issue number> <Change title>
Contents
This PR is trying to resolve:
TBD
We resolve it by:
TBD
Checklist
mainto my branch.