Skip to content

52 av dev up to date#126

Merged
Av3boy merged 11 commits into
devfrom
52-av-dev-up-to-date
Jan 4, 2026
Merged

52 av dev up to date#126
Av3boy merged 11 commits into
devfrom
52-av-dev-up-to-date

Conversation

@Av3boy
Copy link
Copy Markdown
Owner

@Av3boy Av3boy commented Jan 4, 2026

<Issue number> <Change title>

Contents

This PR is trying to resolve:
TBD

We resolve it by:
TBD

Checklist

  • I have merged the latest changes from main to my branch.
  • I have tested my changes and any affected components.
  • I have added the proper documentation about my changes
  • I have made sure there is no overlapping work.
  • I have discussed any / all issues brought up from code review.

Av3boy and others added 11 commits December 13, 2025 15:39
on-behalf-of: @Azure opensource@microsoft.com
* #52 Temp

* #52 Test

---------

Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com>
on-behalf-of: @Azure opensource@microsoft.com
Removed unnecessary div tags from the README.
* WIP on main

* Remove launcher and editor

* Cleanup readme

---------

Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com>
@Av3boy Av3boy self-assigned this Jan 4, 2026
Copilot AI review requested due to automatic review settings January 4, 2026 21:34
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 4, 2026

@Av3boy Av3boy merged commit 42dfdba into dev Jan 4, 2026
5 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to be a major restructuring effort that removes significant portions of the codebase from the repository. The title "52 av dev up to date" suggests this is syncing changes from a dev branch.

Key changes:

  • Deletion of the entire Portal project (backend, database, and web UI)
  • Deletion of all Shared libraries (SharpEngine.Shared, SharpEngine.Rest, SharpEngine.Identity, sharpengine-ui-shared)
  • Removal of multiple Launcher UI components and styles
  • Update of project references in the solution file to point to an external SharpEngine-Shared directory
  • Addition of badges to README.md (some with placeholders)

Reviewed changes

Copilot reviewed 252 out of 277 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Engine/SharpEngine.slnx Updated project references to point to external SharpEngine-Shared directory (../../)
README.md Added new badges including NuGet downloads (with placeholder), launcher description
Shared/* Complete removal of all shared libraries and UI components
Portal/* Complete removal of Portal backend, database, and frontend projects
Engine/Launcher/* Removal of various UI components, styles, and configuration files

Critical Issues:

  1. The external project references may cause build failures if the directory structure isn't consistent across all environments
  2. The PR description is incomplete (all TBDs), providing no context for these major deletions
  3. A placeholder ("PACKAGE_NAME") remains in the README badge that needs to be replaced

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Engine/SharpEngine.slnx
Comment on lines +58 to 63
<Project Path="../../SharpEngine-Shared/SharpEngine.Rest/SharpEngine.Rest.csproj">
<BuildType Solution="LauncherNonWindows|*" Project="Release" />
</Project>
<Project Path="../Shared/SharpEngine.Shared/SharpEngine.Shared.csproj">
<Project Path="../../SharpEngine-Shared/SharpEngine.Shared/SharpEngine.Shared.csproj">
<BuildType Solution="LauncherNonWindows|*" Project="Release" />
</Project>
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project paths have been changed from ../Shared/ to ../../SharpEngine-Shared/, indicating that the shared projects have been moved to a different repository or directory structure. However, these paths point outside the current repository (../../), which suggests they're referencing an external location. This could cause build failures if the SharpEngine-Shared directory doesn't exist at that relative path on all development machines. Consider documenting this dependency structure or using a more robust reference mechanism like Git submodules or NuGet packages.

Copilot uses AI. Check for mistakes.
Comment thread README.md
<div align="center">

[![NuGet Version](https://img.shields.io/nuget/v/SharpEngine.Core.NET)](https://www.nuget.org/packages/SharpEngine.Core.NET)
![NuGet Downloads](https://img.shields.io/nuget/dt/PACKAGE_NAME)
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder text "PACKAGE_NAME" in the NuGet Downloads badge needs to be replaced with the actual package name. This badge will not function correctly until the placeholder is updated.

Copilot uses AI. Check for mistakes.
Comment thread README.md
<div align="center">

[![NuGet Version](https://img.shields.io/nuget/v/SharpEngine.Core.NET)](https://www.nuget.org/packages/SharpEngine.Core.NET)
![NuGet Downloads](https://img.shields.io/nuget/dt/PACKAGE_NAME)
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description contains only "TBD" placeholders with no actual description of what changes are being made. Given the massive scope of this PR (deletion of entire Portal and Shared directories), this lacks critical information about why these deletions are occurring, whether they're intentional, and what the migration strategy is. The PR should be updated with a proper description explaining the restructuring.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants