Open
Conversation
timunie
force-pushed
the
feature/VirtualizingWrapPanel
branch
from
f93e7d0 to
1529ce2
Compare
timunie
force-pushed
the
feature/VirtualizingWrapPanel
branch
from
6a20242 to
d80bd54
Compare
Contributor
Author
|
I think the code is ready for a first review. |
timunie
force-pushed
the
feature/VirtualizingWrapPanel
branch
from
1fe357d to
dbac3b4
Compare
Contributor
Author
|
If one has different sized items, it is hard to predict how to navigate in this scenario, at least when it comes to navigate rows. Therefore, I decided to disable row navigation when items are of different size. However, a developer can override From my point of view, the control is ready for review. |
timunie
changed the title
timunie
force-pushed
the
feature/VirtualizingWrapPanel
branch
from
59cfcbf to
e9a6370
Compare
It is still best to use `IItemSizeProvider` where possible if Items have different sizes
- Navigation via arrow keys works now - ghost element is gone
In such a case a prediction of the element to target is not easy. So we will disable it for now.
timunie
force-pushed
the
feature/VirtualizingWrapPanel
branch
from
e9a6370 to
9cf09e1
Compare
Scrolling with huge collections is now much more performant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a virtualizing wrap panel.