Conversation
AvdLee
requested review from
BasThomas,
amirdew and
kairadiagne
as code owners
| import MetricKit | ||
|
|
||
| protocol Loggable { | ||
|
|
Collaborator
There was a problem hiding this comment.
⚠️ Lines should not have trailing whitespace. (trailing_whitespace)
| return message.data(using: .utf8) | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
⚠️ Lines should not have trailing whitespace. (trailing_whitespace)
Collaborator
Code Coverage Report
Generated by 🚫 Danger Swift against f3ccc5c |
kairadiagne
approved these changes
Feb 11, 2022
kevinrenskers
approved these changes
Feb 15, 2022
Contributor
kevinrenskers
left a comment
kevinrenskers
left a comment
There was a problem hiding this comment.
There are some SwiftLint warnings, but yeah code looks good to me
Owner
Author
Yes, fixed them in the other PR! |
Collaborator
|
Congratulations! 🎉 This was released as part of Release 3.0.0 🚀 Generated by GitBuddy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long text would not easily be readable since it requires us to scroll horizontally. This is a quick win that will improve readability