Update example and readme#115
Conversation
|
Thanks, @mikakruschel! I don't really understand, however. We (for now) went for making it optional, and that is reflected in the example. You now changed both the implementation and the example? |
|
As you can in the commit e75d7e4 and this line: |
|
Oh 😅, seems like I missed that. Thanks! |
AvdLee
left a comment
There was a problem hiding this comment.
Ah, yeah, completely forgot about updating the example and readme. Thanks a ton for this! 💪
Code Coverage Report
Generated by 🚫 Danger Swift against fc28bed |
|
Congratulations! 🎉 This was released as part of Release 4.0.0 🚀 Generated by GitBuddy |
Hey there, thanks for making Diagnostics public, I think it's a cool way to debug apps in production.
I saw that you had a discussion about whether to use an optional array or just an empty array (e75d7e4) and decided to go the non-optional way. It seems though that you forgot to change the example, so that's what this pull request is.