Skip to content

Clean up the project by fixing SwiftLint warnings#147

Merged
AvdLee merged 1 commit intomasterfrom
feature/fix-swiftlint-warnings
Apr 24, 2023
Merged

Clean up the project by fixing SwiftLint warnings#147
AvdLee merged 1 commit intomasterfrom
feature/fix-swiftlint-warnings

Conversation

@AvdLee
Copy link
Owner

@AvdLee AvdLee commented Apr 24, 2023

It turned out we had quite some warnings to solve based on SwiftLint feedback.

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Apr 24, 2023

Messages
📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.352 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.026s)
📖 Slowest test: DiagnosticsReporterTests/testWithoutProvidingSmartInsightsProvider() (2.008s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningExtraInsights() (2.007s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 69.14% ⚠️

SwiftLint found issues

Severity File Reason
Warning AppDelegate.swift:8 The disabled 'line_length' rule should be re-enabled before the end of the file (blanket_disable_command)
Warning DiagnosticsReporter.swift:8 The disabled 'line_length' rule should be re-enabled before the end of the file (blanket_disable_command)

Generated by 🚫 Danger Swift against cfdb1ed

Base automatically changed from feature/sendable to master April 24, 2023 12:34
@AvdLee AvdLee merged commit c0be659 into master Apr 24, 2023
@AvdLee AvdLee deleted the feature/fix-swiftlint-warnings branch April 24, 2023 13:08
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.4.1 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants