Updated logDescription of MXCrashDiagnostic with human-readable exception type and signal#151
Merged
AvdLee merged 2 commits intoAvdLee:masterfrom Jun 1, 2023
Conversation
edorphy
requested review from
AvdLee,
BasThomas,
kairadiagne,
neodym and
raphkoebraam
as code owners
Collaborator
Code Coverage Report
SwiftLint found issues
Generated by 🚫 Danger Swift against ffdb980 |
Owner
|
@edorphy thanks for your contribution! Our repository requires signed commits. Would it be possible for you to enable signed commits and recommit using the following command: You can read more about setting up signed commits here. |
…tion type and signal
edorphy
force-pushed
the
features/crash-diagnostic-loggable
branch
from
d36b161 to
de8981f
Compare
Contributor
Author
|
I fixed the SwiftLint warnings and errors that I introduced :D. Should be good now. |
AvdLee
approved these changes
Jun 1, 2023
Owner
AvdLee
left a comment
AvdLee
left a comment
There was a problem hiding this comment.
Great job, thanks a lot for taking care of signing your commits! Let's go!
Collaborator
|
Congratulations! 🎉 This was released as part of Release 4.5.0 🚀 Generated by GitBuddy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#149
Updated the logDescription of the MXCrashDiagnostic to print the human-readable lookups for the exception type and signals defined in iOS SDK header files using custom string interpolations.