Skip to content

Trivial title fix.#59

Merged
AvdLee merged 2 commits intoAvdLee:masterfrom
davidsteppenbeck:trivial-title-fix
Feb 28, 2020
Merged

Trivial title fix.#59
AvdLee merged 2 commits intoAvdLee:masterfrom
davidsteppenbeck:trivial-title-fix

Conversation

@davidsteppenbeck
Copy link
Contributor

No description provided.

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've added a small addition, as we're automatically generating the changelog there's no need to change it manually 🙂


static func report() -> DiagnosticsChapter {
return DiagnosticsChapter(title: "Logs", diagnostics: diagnostics, formatter: self)
return DiagnosticsChapter(title: title, diagnostics: diagnostics, formatter: self)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ghost
Copy link

ghost commented Feb 27, 2020

Warnings
⚠️ Please provide a summary in the Pull Request description
Messages
📖

View more details on Bitrise

📖 Diagnostics: Executed 18 tests, with 0 failures (0 unexpected) in 0.241 (0.370) seconds

Diagnostics.framework: Coverage: 76.97

File Coverage
LogsReporter.swift 92.86%

Generated by 🚫 Danger Swift against 6d933a5

@AvdLee AvdLee merged commit 17586b3 into AvdLee:master Feb 28, 2020
@ghost
Copy link

ghost commented Feb 28, 2020

Congratulations! 🎉 This was released as part of Release 1.6.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants