Skip to content

native (aka non-catalyst) macOS support added#75

Merged
AvdLee merged 2 commits intoAvdLee:masterfrom
JulianKahnert:master
Nov 5, 2020
Merged

native (aka non-catalyst) macOS support added#75
AvdLee merged 2 commits intoAvdLee:masterfrom
JulianKahnert:master

Conversation

@JulianKahnert
Copy link
Contributor

Hi, first of all: thank you for this awesome framework! 🙂

I want to use it with a non-catalyst app and added a enum Device that wraps the os specific information.
What do you think of this solution?

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and very welcome! If you like, feel free to also update the readme to state out Mac support 💪

Thanks a lot!

@@ -137,7 +141,7 @@ extension DiagnosticsLogger {
queue.async { [unowned self] in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ It is safer to use weak instead of unowned

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Nov 4, 2020

Fails
🚫 Failed to get the coverage - Error: The data couldn’t be read because it isn’t in the correct format.
🚫 error: Build input file cannot be found: '/Users/vagrant/git/Sources/Extensions/UIDeviceExtensions.swift' (in target 'Diagnostics' from project 'Diagnostics')
Warnings
⚠️

Sources/DiagnosticsLogger.swift#L176 - It is safer to use weak instead of unowned

Messages
📖

View more details on Bitrise

Generated by 🚫 Danger Swift against f07a783

@JulianKahnert
Copy link
Contributor Author

Hi @AvdLee, I have added a comment and created this macOS example project. 🙂

@JulianKahnert
Copy link
Contributor Author

Oh I just saw that I have to fix the xcode project file before we can merge this. I have used the Package.swift file before.

@AvdLee
Copy link
Owner

AvdLee commented Nov 5, 2020

@JulianKahnert thanks for the readme update! I don't think we need an example project with your example code inside the readme. I'm going to merge this in!

@AvdLee AvdLee merged commit 8393dc9 into AvdLee:master Nov 5, 2020
@JulianKahnert
Copy link
Contributor Author

@AvdLee sry for being not precise. The current master branch version fails to build, because I have not updated the Diagnostics.xcodeproj, which is also indicated by this error:

error: Build input file cannot be found: '/Users/vagrant/git/Sources/Extensions/UIDeviceExtensions.swift' (in target 'Diagnostics' from project 'Diagnostics')

https://github.com/JulianKahnert/Diagnostics/commit/cf2445c33754a4c0ca8f9a42dc55c05388f02f5d will fix the problem. But since the PR is already merged, the changes do not appear here.

@JulianKahnert JulianKahnert mentioned this pull request Nov 5, 2020
@JulianKahnert
Copy link
Contributor Author

I have cherry picked the changes and created #76 . With that PR merged, the problem should be fixed.

@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.8.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants