native (aka non-catalyst) macOS support added#75
native (aka non-catalyst) macOS support added#75AvdLee merged 2 commits intoAvdLee:masterfrom JulianKahnert:master
Conversation
AvdLee
left a comment
There was a problem hiding this comment.
This is awesome and very welcome! If you like, feel free to also update the readme to state out Mac support 💪
Thanks a lot!
| @@ -137,7 +141,7 @@ extension DiagnosticsLogger { | |||
| queue.async { [unowned self] in | |||
There was a problem hiding this comment.
⚠️ It is safer to use weak instead of unowned
Generated by 🚫 Danger Swift against f07a783 |
|
Oh I just saw that I have to fix the xcode project file before we can merge this. I have used the |
|
@JulianKahnert thanks for the readme update! I don't think we need an example project with your example code inside the readme. I'm going to merge this in! |
|
@AvdLee sry for being not precise. The current master branch version fails to build, because I have not updated the https://github.com/JulianKahnert/Diagnostics/commit/cf2445c33754a4c0ca8f9a42dc55c05388f02f5d will fix the problem. But since the PR is already merged, the changes do not appear here. |
|
I have cherry picked the changes and created #76 . With that PR merged, the problem should be fixed. |
|
Congratulations! 🎉 This was released as part of Release 1.8.0 🚀 Generated by GitBuddy |
Hi, first of all: thank you for this awesome framework! 🙂
I want to use it with a non-catalyst app and added a
enum Devicethat wraps the os specific information.What do you think of this solution?