Adds ability to customise status views tint color.#21
Merged
AvdLee merged 3 commits intoAvdLee:mainfrom Feb 23, 2023
Merged
Conversation
anmolmalhotra
requested review from
AvdLee,
hiddevdploeg and
jordibruin
as code owners
anmolmalhotra
changed the title
Collaborator
|
Thanks for this! I'll wait for Hidde to have a look since he's more into the design part than I am! |
AvdLee
approved these changes
Feb 22, 2023
Owner
AvdLee
left a comment
AvdLee
left a comment
There was a problem hiding this comment.
Looks good from my perspective!
Collaborator
|
Nice job! |
Contributor
Author
|
@hiddevdploeg done. 😊 |
Owner
|
Thanks for implementing our feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to let you customise tint color to status views.
The implementation is inspired from #11. I have added a closure of type
(String) -> ColorinRoadmapStyle. The default value isColor.primary.Fixes #11