fix(icons): apply file path substitutions in launcher icon resolution#1877
Merged
Purian23 merged 1 commit intoAvengeMedia:masterfrom Mar 1, 2026
Merged
Conversation
Follow-up to AvengeMedia#1867. The launcher's AppIconRenderer used its own Quickshell.iconPath() call without going through appIdSubstitutions, so PWA icons configured via regex file path rules were not resolved in the app launcher.
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1867. The launcher's
AppIconRenderer.qmlresolved icons via its ownQuickshell.iconPath()call without going throughappIdSubstitutions, so PWA icons configured via regex file path rules were not resolved in the app launcher (only in the taskbar/workspace widget).This adds the same
Paths.moddedAppId()check before falling through to the default icon lookup, matching the pattern established inPaths.getAppIcon().Test plan
^(chrome|msedge|chromium)-(.+)$→/home/user/.local/share/icons/hicolor/128x128/apps/$1-$2.png)