added non-flake nix compatibility with flake-compat#2009
added non-flake nix compatibility with flake-compat#2009LuckShiba merged 2 commits intoAvengeMedia:masterfrom
Conversation
LuckShiba
left a comment
There was a problem hiding this comment.
The addition looks okay, but I'm thinking about how necessary that is. Users that doesn't want to use the flake should in a best-case scenario use the Nixpkgs module, but it's still not in stable so I guess that is okay.
The only problem here is that it'll add two new top-level Nix files, which is okay but not ideal. @sunworms, I don't know much about non-flake usage, would it be viable having these files inside distro/nix or not at all?
|
By testing here it seems to work by moving the files to |
|
@sunworms have you looked into the last comment by LuckShiba? I would like to get this in or cleared out if we can. |
That could work too, I kept them top-level because it'll be easier for people who use something like let
sources = import ./npins; # or wherever their npins directory is
dms = import sources.dms {};
in
{
imports = [
dms.nixosModules.default
];
programs.dank-material-shell.enable = true;
} |
|
Since it's more of an edge case (most people use flakes!) I've decided to change them to It also shouldn't be basically any much different for, as in your example, npins users: let
sources = import ./npins;
dms = import (sources.dms + "/distro/nix") {};
in
{
imports = [
dms.nixosModules.default
];
programs.dank-material-shell.enable = true;
}Thank you for your contribution! |
This PR aims to add compatibility for non-flake setups by adding the input
NixOS/flake-compatand creating adefault.nixand ashell.nixthat provide the same outputs as the ones provided by the flake.