feat(tools): add Tools tab with Trace Path and Line of Sight#67
Merged
Conversation
Add a new Tools tab between Map and Settings to consolidate diagnostic tools: - Create ToolsView with navigation to Trace Path and Line of Sight - Remove Trace Path from Contacts toolbar menu - Remove Line of Sight from Map view
Avi0n
added a commit
that referenced
this pull request
Mar 18, 2026
- Work around MapLibre bug where MLNEffectiveScaleFactorForView uses nativeBounds.width / bounds.width, which gives wrong scale in landscape because nativeBounds is fixed while bounds rotates with the device - Isa-swizzle the internal Metal UIView's setDrawableSize: to compute bounds × nativeScale instead of the buggy ratio - Use non-zero initial frame to avoid zero-size Metal init (issue #67) - Fix mapStyleChanged always false when style URL changes - Remove empty setupPointLayers stub, pass mapView param to setupRasterSources
Avi0n
added a commit
that referenced
this pull request
Mar 20, 2026
- Work around MapLibre bug where MLNEffectiveScaleFactorForView uses nativeBounds.width / bounds.width, which gives wrong scale in landscape because nativeBounds is fixed while bounds rotates with the device - Isa-swizzle the internal Metal UIView's setDrawableSize: to compute bounds × nativeScale instead of the buggy ratio - Use non-zero initial frame to avoid zero-size Metal init (issue #67) - Fix mapStyleChanged always false when style URL changes - Remove empty setupPointLayers stub, pass mapView param to setupRasterSources
Avi0n
added a commit
that referenced
this pull request
Mar 26, 2026
- Work around MapLibre bug where MLNEffectiveScaleFactorForView uses nativeBounds.width / bounds.width, which gives wrong scale in landscape because nativeBounds is fixed while bounds rotates with the device - Isa-swizzle the internal Metal UIView's setDrawableSize: to compute bounds × nativeScale instead of the buggy ratio - Use non-zero initial frame to avoid zero-size Metal init (issue #67) - Fix mapStyleChanged always false when style URL changes - Remove empty setupPointLayers stub, pass mapView param to setupRasterSources
Avi0n
added a commit
that referenced
this pull request
Mar 27, 2026
- Work around MapLibre bug where MLNEffectiveScaleFactorForView uses nativeBounds.width / bounds.width, which gives wrong scale in landscape because nativeBounds is fixed while bounds rotates with the device - Isa-swizzle the internal Metal UIView's setDrawableSize: to compute bounds × nativeScale instead of the buggy ratio - Use non-zero initial frame to avoid zero-size Metal init (issue #67) - Fix mapStyleChanged always false when style URL changes - Remove empty setupPointLayers stub, pass mapView param to setupRasterSources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrench.and.screwdrivericonToolsViewcontaining navigation to Trace Path and Line of SightTest plan