fix(index): correct P2PKH script byte index [22]->[23] in address ind…#239
Merged
cdonnachie merged 1 commit into5.xfrom Apr 7, 2026
Merged
fix(index): correct P2PKH script byte index [22]->[23] in address ind…#239cdonnachie merged 1 commit into5.xfrom
cdonnachie merged 1 commit into5.xfrom
Conversation
…exing The P2PKH script pattern check used script[22] == OP_EQUALVERIFY, but byte [22] is the last byte of the 20-byte hash160 payload. OP_EQUALVERIFY is at byte [23]. This caused ~99.6% of all P2PKH outputs to be silently skipped when building the address index in ConnectBlock, DisconnectBlock, and the mempool address index. Also fix getaddressutxos and getaddressdeltas RPC defaults from AVN-only to '*' (all assets) so P2PKH-only addresses return results correctly. Affected sites: - src/validation.cpp: DisconnectBlock outputs/inputs, ConnectBlock inputs/outputs (4 sites) - src/txmempool.cpp: addAddressIndex inputs/outputs, addSpentIndex (3 sites) - src/rpc/indexes.cpp: getaddressutxos, getaddressdeltas default assetName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The P2PKH script pattern check used script[22] == OP_EQUALVERIFY, but byte [22] is the last byte of the 20-byte hash160 payload. OP_EQUALVERIFY is at byte [23]. This caused ~99.6% of all P2PKH outputs to be silently skipped when building the address index in ConnectBlock, DisconnectBlock, and the mempool address index.
Also fix getaddressutxos and getaddressdeltas RPC defaults from AVN-only to '*' (all assets) so P2PKH-only addresses return results correctly.
Affected sites: