Refactor/baseindex address spent timestamp#240
Merged
cdonnachie merged 12 commits into5.xfrom Apr 15, 2026
Merged
Conversation
… framework - Remove legacy BlockTreeDB-embedded address/spent/timestamp index methods from node/blockstorage.h/.cpp and all 6 helper functions from validation.h/.cpp - Remove old ConnectBlock/DisconnectBlock inline index-building code from validation.cpp; indexing is now handled by BaseIndex subclasses - Add src/index/addressindex.h/.cpp: AddressIndex : BaseIndex, exposes ReadAddressIndex() and ReadAddressUnspentIndex() - Add src/index/spentindex.h/.cpp: SpentIndex : BaseIndex, exposes ReadSpentIndex() - Add src/index/timestampindex.h/.cpp: TimestampIndex : BaseIndex - init.cpp: construct index instances via make_unique and set fXxxIndex flags - rpc/indexes.cpp: replace GetAddressIndex/GetSpentIndex free-function calls with g_addressindex->ReadAddressIndex() / g_spentindex->ReadSpentIndex() - validation.cpp FinalizeSubpackage: call addAddressIndex/addSpentIndex after ChangeSet::Apply() so unconfirmed mempool transactions populate the in-memory address/spent maps (fixes getaddressmempool returning empty results)
…x (NewIterator is non-const)
…ampIndex (NewIterator is non-const)
listaddressesbyasset and listassetbalancesbyaddress both iterated
passets->mapAssetsAddressAmount which is cleared on every chainstate
flush (DumpCacheToDatabase -> ClearDirtyCache), causing both RPCs to
return {} after the first flush.
Fix by reading persisted balances from LevelDB (AssetAddressDir /
AddressDir) and overlaying any unsaved in-memory dirty entries on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.