Skip to content

fix: correct OpusCompile workflow for shim linking on Windows and Linux x86 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SineVector241 merged 2 commits into from
Apr 8, 2026
Merged

fix: correct OpusCompile workflow for shim linking on Windows and Linux x86 #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7c0124
fix: correct build with shim step for Windows and Linux x86
katruud Apr 8, 2026
550ba10
fix: resolve Windows x86 linker error for missing SEH symbol
katruud Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/OpusCompile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,10 @@ jobs:
- name: Build with shim
working-directory: ./build
run: |
if [[ "${{ matrix.arch }}" == "x64" || "${{ matrix.arch }}" == "x86" ]]; then
CC=gcc
if [[ "${{ matrix.arch }}" == "x64" ]]; then
CC="gcc -m64"
elif [[ "${{ matrix.arch }}" == "x86" ]]; then
CC="gcc -m32"
elif [[ "${{ matrix.arch }}" == "arm64" ]]; then
CC=${{ env.C_COMPILER }}
elif [[ "${{ matrix.arch }}" == "arm32" ]]; then
Expand Down Expand Up @@ -209,9 +211,10 @@ jobs:
working-directory: ./build
shell: cmd
run: |
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" ${{ env.ARCH }}
cl /O2 /I..\opus\include /c ..\OpusSharp.Natives\opus_shim.c /Foopus_shim.obj
link /DLL /OUT:opus.dll /DEF:NUL opus_shim.obj Release\opus.lib
if "${{ env.ARCH }}"=="Win32" (set "VCARCH=x86") else if "${{ env.ARCH }}"=="x64" (set "VCARCH=amd64") else if "${{ env.ARCH }}"=="ARM64" (set "VCARCH=amd64_arm64") else if "${{ env.ARCH }}"=="ARM" (set "VCARCH=amd64_arm")
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" %VCARCH%
cl /O2 /MD /I..\opus\include /c ..\OpusSharp.Natives\opus_shim.c /Foopus_shim.obj
link /DLL /OUT:opus.dll opus_shim.obj Release\opus.lib ucrt.lib vcruntime.lib msvcrt.lib

- name: Upload Artifact
uses: actions/upload-artifact@v4
Expand Down
Loading