feat(wallpaper): discover runtime resource packs via Wallpapers path#13
Merged
Merged
Conversation
Add support for discovering third-party wallpaper resource packs at runtime, with zero compile-time coupling to any specific pack (e.g. CF-Gallery): no submodule, no #ifdef, no CMake option. Whether a pack is "enabled" is simply whether it is installed into the discovered location. - base/path: add a Wallpapers PathType resolving to <desktop_active_root>/Wallpapers/, auto-created by setup() like the other standard directories. - base/file_operations: add filter_target_recursive(), an additive companion to filter_target() that descends into subdirectories so packs installed under wallpapers/<pack>/ are found. Existing flat callers are unaffected. - desktop/wallpaper: rework make_layer() to pick the first source that actually yields images (config source_path -> Pictures, flat; then Wallpapers, recursive). This also fixes a latent issue where an empty Pictures directory left the desktop without a wallpaper even when a bundled pack was available. Users without a pack see no change. CF-Gallery (CC BY-NC-ND 4.0) is consumed as such a pack: installing it into Wallpapers/cfgallery/ surfaces its images. The pack's own install rule lives in the CF-Gallery repo, not here. The wallpaper animation/rotation engine (gradient/movement switching) remains a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for discovering third-party wallpaper resource packs at runtime, with zero compile-time coupling to any specific pack (e.g. CF-Gallery): no submodule, no #ifdef, no CMake option. Whether a pack is "enabled" is simply whether it is installed into the discovered location.
CF-Gallery (CC BY-NC-ND 4.0) is consumed as such a pack: installing it into Wallpapers/cfgallery/ surfaces its images. The pack's own install rule lives in the CF-Gallery repo, not here. The wallpaper animation/rotation engine (gradient/movement switching) remains a follow-up.