Add script for generating test data, and a test of lambert_w0, sp_lambert_w0, lambert_wm1, sp_lambert_wm1#15
Conversation
|
The code appears to be perfect. However, as it's currently midnight in Korea, I've already left the lab for the day. I'll thoroughly review and incorporate your changes after I return to work tomorrow morning. I kindly ask for your understanding in this matter. |
|
Of course. I will work on moving the functions and their tests into their own file in the meantime. |
lambert_w and sp_lambert_wlambert_w0, sp_lambert_w0, lambert_wm1, sp_lambert_wm1
lambert_w0, sp_lambert_w0, lambert_wm1, sp_lambert_wm1lambert_w0, sp_lambert_w0, lambert_wm1, sp_lambert_wm1
|
Thank you for your excellent contribution, @JSorngard! Your work on implementing tests for the Lambert W functions is truly impressive. I'd like to share some thoughts on your changes and propose a few adjustments. I'd greatly appreciate your input on these ideas:
If you're comfortable with these suggestions, I'd like to proceed with the following changes:
I value your input and would be happy to discuss any concerns or alternative ideas you might have. If these changes sound good to you, I plan to first merge your current pull request and then start working on these additional modifications directly in the repository. Once again, thank you for your valuable contribution and the impressive accuracy of the Lambert W functions. Your work significantly enhances the quality of our library. |
|
I think the file restructure and module renaming is a very good idea. It would make it clearer, and simpler. Moving the tests make sense I think. Regarding the prelude, would it not work for the user to do |
|
Thank you for your feedback. I really appreciate your insights.
Thank you again for your contributions and thoughtful feedback. It's helping us make puruspe more intuitive and user-friendly. I'll start implementing these changes right after merging the current PR. |
This is my proposal for a test of the Lambert W functions.